scripts: use SSH connection check instead of ping for host verification #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noki
reviewed
Feb 6, 2025
mass-update.sh
Outdated
| @@ -60,7 +60,7 @@ fi | |||
| # Function to check reachability | |||
| check_reachability() { | |||
| local hostname="$1" | |||
| if ping -4 -c 1 "$hostname" >/dev/null 2>&1 || ping -6 -c 1 "$hostname" >/dev/null 2>&1; then | |||
| if ssh -q -o StrictHostKeyChecking=no -o BatchMode=yes -o ConnectTimeout=5 "$hostname" exit >/dev/null 2>&1; then | |||
There was a problem hiding this comment.
should be root@$hostname otherwise it will only work if you are already root.
|
Thank you for this one! This is great! The only downside is that without a password prompt we can't update the old nanosations with this anymore as they don't support ed25519 and require rsa due to limitations of the tiny target. But creating an additional RSA key for that is probably the way to go and the tiny targets were always a bit problematic to flash anyway. |
To run the mass update script, you must be connected to the internal mesh network. If you're not connected, the script will report that routers or access points cannot be found. However, many users connect via proxy jumps through our gateways to manage devices via SSH. In its current state, the script relies on ping to verify connectivity, which fails when SSH access is possible but ping is not working. This update changes the script to check for an active SSH connection instead of relying on ping. This ensures that the SSH daemon is up and reachable, providing a more accurate verification of host availability, rather than just testing for ICMP echo requests.
Noki
force-pushed
the
ssh-connec-check-massupdate
branch
from
374a7c5 to
4f2a98c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run the mass update script, you must be connected to the internal mesh network. If you're not connected, the script will report that routers or access points cannot be found. However, many users connect via proxy jumps through our gateways to manage devices via SSH. In its current state, the script relies on ping to verify connectivity, which fails when SSH access is possible but ping is not working.
This update changes the script to check for an active SSH connection instead of relying on ping. This ensures that the SSH daemon is up and reachable, providing a more accurate verification of host availability, rather than just testing for ICMP echo requests.